Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL: add libcaca video driver #317580

Closed
wants to merge 1 commit into from
Closed

SDL: add libcaca video driver #317580

wants to merge 1 commit into from

Conversation

devplayer0
Copy link
Contributor

@devplayer0 devplayer0 commented Jun 5, 2024 •
edited
Loading

SDL 1.2 has support for the libcaca library, which allows for rendering to ASCII art. Games with software rendering (e.g. Chocolate Doom) can then render to a terminal.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from lovek323 June 5, 2024 23:18
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1735

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 11, 2024
@AndersonTorres
Copy link
Member

P.S.: since this change is causing mass-rebuild red flags, cherry-pick it over Staging.

  1. Mark this PR as draft (or else the world will be pinged if anything goes astray)
  2. Read this: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

@devplayer0 devplayer0 marked this pull request as draft June 12, 2024 13:11
@devplayer0 devplayer0 changed the base branch from master to staging June 12, 2024 13:24
@devplayer0 @osjack
SDL: add libcaca video driver
6e7a486 
SDL 1.2 has support for the libcaca library, which allows for rendering
to ASCII art. Games with software rendering (e.g. Chocolate Doom) can
then render to a terminal.
AndersonTorres
AndersonTorres approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is OK to merge. You can undraft.

@rhendric rhendric marked this pull request as ready for review June 13, 2024 03:15
@rhendric rhendric added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jun 13, 2024
@devplayer0
Copy link
Contributor Author

Now it is OK to merge. You can undraft.

Thanks :)

@devplayer0 devplayer0 closed this Jul 2, 2024
@devplayer0 devplayer0 deleted the sdl-libcaca branch July 2, 2024 12:57
@AndersonTorres
Copy link
Member

My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@rhendric rhendric rhendric approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devplayer0 @nixos-discourse @AndersonTorres @rhendric @wegank